[PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

KY Srinivasan kys at microsoft.com
Wed Jul 9 20:01:30 UTC 2014



> -----Original Message-----
> From: Christoph Hellwig [mailto:hch at infradead.org]
> Sent: Wednesday, July 9, 2014 1:42 AM
> To: KY Srinivasan
> Cc: linux-kernel at vger.kernel.org; devel at linuxdriverproject.org;
> ohering at suse.com; jbottomley at parallels.com; jasowang at redhat.com;
> apw at canonical.com; linux-scsi at vger.kernel.org; stable at vger.kernel.org
> Subject: Re: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS
> protocol version
> 
> > +	if ((vmbus_proto_version == VERSION_WS2008) ||
> > +	     (vmbus_proto_version == VERSION_WIN7)) {
> 
> This has superflous braces and doesn't use proper Linux indentation.
> 
> But I think simply using a switch here might be cleaner anyway.
I will do as you have suggested.

K. Y


More information about the devel mailing list