[PATCH 1/2] staging: silicom: checkpatch fixes
Dan Carpenter
dan.carpenter at oracle.com
Wed Jul 9 09:38:08 UTC 2014
The patch does too many things, break it up into one type of fix per
patch.
On Tue, Jul 01, 2014 at 02:24:36PM +0200, Davide Gianforte wrote:
> Chechpatch.pl cleanup
>
> There are still some warnings, most of them are lines over 80 chars
> (mainly a semicolon or closing parenthesis).
>
> Where not specified, I defaulted printk with no log level into pr_debug
No. You can't just use pr_debug for everything. Also some of them are
not whole line prints so the pr_debug() will put extra info in the
middle of the lines.
Write a hello_world.ko kernel module and play with the printk until you
understand what I mean.
regards,
dan carpenter
More information about the devel
mailing list