[PATCH 8/8] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

Christoph Hellwig hch at infradead.org
Wed Jul 9 08:46:44 UTC 2014


On Tue, Jul 08, 2014 at 05:46:52PM -0700, K. Y. Srinivasan wrote:
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1023,6 +1023,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
>  		case ATA_12:
>  			set_host_byte(scmnd, DID_PASSTHROUGH);
>  			break;
> +		/*
> +		 * On Some Windows hosts TEST_UNIT_READY command can return
> +		 * SRB_STATUS_ERROR, let the upper level code deal with it
> +		 * based on the sense information.
> +		 */
> +		case TEST_UNIT_READY:
> +			break;

Don't we need to set an error in the command for the error handler to
take action?  Or is this propagated elsewhere?



More information about the devel mailing list