[PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

Dexuan Cui decui at microsoft.com
Tue Jul 8 22:17:48 UTC 2014


> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter at oracle.com]
> Sent: Tuesday, July 8, 2014 17:27 PM
> To: Dexuan Cui
> Cc: gregkh at linuxfoundation.org; linux-kernel at vger.kernel.org; driverdev-
> devel at linuxdriverproject.org; plagnioj at jcrosoft.com;
> tomi.valkeinen at ti.com; linux-fbdev at vger.kernel.org; olaf at aepfle.de;
> apw at canonical.com; jasowang at redhat.com; Haiyang Zhang
> Subject: Re: [PATCH v2] video: hyperv: hyperv_fb: refresh the VM screen by
> force on VM panic
> 
> Don't use likely/unlikely unless you have benchmark numbers to show that
> it makes a speed up.
> 
> regards,
> dan carpenter

Hi Dan,
Here the variable 'synchronous_fb' is only set to true when the system panics.
So before the system panics, it's always 'unlikely'. :-)

Thanks,
-- Dexuan


More information about the devel mailing list