[PATCH 1/1] staging: android: logger: fixes not useful "else" warnings This patch fixes WARNING: else is not generally useful after a break or return
kinka
kinkabrain at gmail.com
Thu Jul 3 16:09:23 UTC 2014
Signed-off-by: kinka <kinkabrain at gmail.com>
---
drivers/staging/android/logger.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index 2772e01..830182b 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -110,8 +110,9 @@ static inline struct logger_log *file_get_log(struct file *file)
struct logger_reader *reader = file->private_data;
return reader->log;
- } else
- return file->private_data;
+ }
+
+ return file->private_data;
}
/*
@@ -159,8 +160,8 @@ static size_t get_user_hdr_len(int ver)
{
if (ver < 2)
return sizeof(struct user_logger_entry_compat);
- else
- return sizeof(struct logger_entry);
+
+ return sizeof(struct logger_entry);
}
static ssize_t copy_header_to_user(int ver, struct logger_entry *entry,
--
1.8.3.2
More information about the devel
mailing list