[PATCH] Staging: rtl8192e: Fix potential NULL pointer dereference
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Wed Jul 2 16:33:34 UTC 2014
On Wed, Jul 02, 2014 at 11:25:51AM +0200, Emil Goode wrote:
> We need to make sure the struct rtllib_device pointer ieee is not NULL
> after the goto rx_dropped label since it is dereferenced there.
>
> Signed-off-by: Emil Goode <emilgoode at gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_rx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 60de54c..7db3e74 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -1496,7 +1496,8 @@ int rtllib_rx(struct rtllib_device *ieee, struct sk_buff *skb,
> return ret;
>
> rx_dropped:
> - ieee->stats.rx_dropped++;
> + if (ieee)
> + ieee->stats.rx_dropped++;
> return 0;
> }
> EXPORT_SYMBOL(rtllib_rx);
Is this something that is hitting users today in the tree, or is this
just a bug you found looking at the code?
thanks,
greg k-h
More information about the devel
mailing list