[PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

Greg KH gregkh at linuxfoundation.org
Thu Jan 23 19:45:10 UTC 2014


On Thu, Jan 23, 2014 at 09:37:28PM +0200, Valentina Manea wrote:
> On Thu, Jan 23, 2014 at 9:09 PM, Greg KH <gregkh at linuxfoundation.org> wrote:
> > On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote:
> >> This driver was previously an interface driver. Since USB/IP
> >> exports a whole device, not just an interface, it would make
> >> sense to be a device driver.
> >>
> >> This patch also modifies the way userspace sees and uses a
> >> shared device - dealing with interfaces is no longer required.
> >
> > In what way is this modified?  What is now different?
> >
> 
> 1. The usbip_status file is no longer created for interface 0, but for
> the whole device (such as
> /sys/devices/pci0000:00/0000:00:01.2/usb1/1-1/usbip_status).
> 2. Per interface information, such as interface class or protocol, is
> no longer sent/received. Only device specific information is
> transmitted.
> 3. Since the driver was moved one level below in the USB architecture,
> there is no need to bind/unbind each interface, just the device as a
> whole.

Please say all of this in your changelog entry :)

thanks,

greg k-h


More information about the devel mailing list