[PATCH] staging: lustre: fix GFP_ATOMIC macro usage

Drokin, Oleg oleg.drokin at intel.com
Wed Jan 22 01:31:34 UTC 2014


Hello!

On Jan 21, 2014, at 3:16 PM, Dan Carpenter wrote:

> We have a leak checker in the kernel but most people disable it.  I
> forget the config name.  There are a bunch of useful debug configs.

I actually use it at times too and it's useful (e.g. it works even if you did not wrap the allocation in the lustre macro, and this did happen before),
but it comes with it's own problems.
E.g. it gobbles on memory like there's no tomorrow (at least in my case), it has horrible false failure ratio with zfs in place (and probably
that's why it uses even more memory then), it has otherwise quite significant failure ratio too.
But yes, it is useful and I am glad it's there. It does not solve some other usecases outlined by Andreas, though.

Bye,
    Oleg


More information about the devel mailing list