[PATCH V2 1/1] Drivers: hv: Implement the file copy service
KY Srinivasan
kys at microsoft.com
Tue Jan 14 23:12:25 UTC 2014
> -----Original Message-----
> From: Olaf Hering [mailto:olaf at aepfle.de]
> Sent: Tuesday, January 14, 2014 2:13 PM
> To: KY Srinivasan
> Cc: gregkh at linuxfoundation.org; linux-kernel at vger.kernel.org;
> devel at linuxdriverproject.org; apw at canonical.com; jasowang at redhat.com
> Subject: Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
>
> On Tue, Jan 14, K. Y. Srinivasan wrote:
>
>
> > +static ssize_t fcopy_write(struct file *file, const char __user *buf,
> > + size_t count, loff_t *ppos)
> > +{
> > + int error = 0;
> > +
> > + if (count != sizeof(int))
> > + return 0;
> > +
> > + if (copy_from_user(&error, buf, sizeof(int)))
> > + return -EFAULT;
> > +
> > + if (in_hand_shake) {
> > + fcopy_handle_handshake();
> > + return 0;
> > + }
>
>
> > + /*
> > + * Register with the kernel.
> > + */
> > + write(fcopy_fd, &version, sizeof(int));
>
>
> Shouldnt there be some version check already even in this initial
> implementation? What if there will be a newer daemon running on an older
> kernel?
Currently, the daemon registers with the kernel passing its version number. I will make the
version check "real".
Thanks,
K. Y
>
> Olaf
More information about the devel
mailing list