[PATCH 4/4] staging: lustre: libcfs_debug: small whitespace cleanups

[Dilger, Andreas]

On 2014/01/13, 6:41 AM, "Salym Senyonga" <salymsash at gmail.com> wrote:

>Just a few minor changes to make columns line up.

I'd prefer that if you are going to line up the columns that this be
done with tabs instead of spaces.  That avoids (or at least reduces)
the need to re-align all of the lines if these structures are changed
in the future.

The first two patches in the series are probably OK.

Cheers, Andreas.

>Signed-off-by: Salym Senyonga <salymsash at gmail.com>
>---
> .../lustre/include/linux/libcfs/libcfs_debug.h     |   24
>++++++++++----------
> 1 files changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>index ccde5826..2bd4885 100644
>--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>@@ -165,18 +165,18 @@ struct ptldebug_header {
> #define CDEBUG_DEFAULT_MIN_DELAY ((cfs_time_seconds(1) + 1) / 2) /*
>jiffies */
> #define CDEBUG_DEFAULT_BACKOFF   2
> struct cfs_debug_limit_state {
>-	cfs_time_t      cdls_next;
>-	unsigned int    cdls_delay;
>+	cfs_time_t   cdls_next;
>+	unsigned int cdls_delay;
> 	int	     cdls_count;
> };
> 
> struct libcfs_debug_msg_data {
>-	const char	       *msg_file;
>-	const char	       *msg_fn;
>-	int		      msg_subsys;
>-	int		      msg_line;
>-	int		      msg_mask;
>-	struct cfs_debug_limit_state  *msg_cdls;
>+	const char *msg_file;
>+	const char *msg_fn;
>+	int	    msg_subsys;
>+	int	    msg_line;
>+	int	    msg_mask;
>+	struct cfs_debug_limit_state *msg_cdls;
> };
> 
> #define LIBCFS_DEBUG_MSG_DATA_INIT(data, mask, cdls)		\
>@@ -228,10 +228,10 @@ do {									\
> 	__CDEBUG(&cdls, mask, format, ## __VA_ARGS__);			\
> } while (0)
> 
>-#define CWARN(format, ...)	  CDEBUG_LIMIT(D_WARNING, format, ##
>__VA_ARGS__)
>-#define CERROR(format, ...)	 CDEBUG_LIMIT(D_ERROR, format, ##
>__VA_ARGS__)
>-#define CNETERR(format, a...)       CDEBUG_LIMIT(D_NETERROR, format, ##
>a)
>-#define CEMERG(format, ...)	 CDEBUG_LIMIT(D_EMERG, format, ##
>__VA_ARGS__)
>+#define CWARN(format, ...)	CDEBUG_LIMIT(D_WARNING, format, ##
>__VA_ARGS__)
>+#define CERROR(format, ...)	CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
>+#define CNETERR(format, a...)	CDEBUG_LIMIT(D_NETERROR, format, ## a)
>+#define CEMERG(format, ...)	CDEBUG_LIMIT(D_EMERG, format, ## __VA_ARGS__)
> 
> #define LCONSOLE(mask, format, ...) CDEBUG(D_CONSOLE | (mask), format,
>## __VA_ARGS__)
> #define LCONSOLE_INFO(format, ...)  CDEBUG_LIMIT(D_CONSOLE, format, ##
>__VA_ARGS__)
>-- 
>1.7.5.4
>
>


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division