[PATCH 3/4] staging: lustre: libcfs_debug.h: remove extra blank lines

Dilger, Andreas andreas.dilger at intel.com
Tue Jan 14 00:43:58 UTC 2014


On 2014/01/13, 6:41 AM, "Salym Senyonga" <salymsash at gmail.com> wrote:

>This patch removes consecutive blank lines.

... but it doesn't leave a single blank line in those places, and in two
cases also appears to remove a single blank line.

To be honest, I'd rather not see minor whitespace-only changes like this
one,
since it makes it harder to merge other patches and doesn't really do much
to improve the readability of this code.

Cheers, Andreas

>Signed-off-by: Salym Senyonga <salymsash at gmail.com>
>---
> .../lustre/include/linux/libcfs/libcfs_debug.h     |    8 --------
> 1 files changed, 0 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>index 0fb5e41..ccde5826 100644
>--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
>@@ -82,7 +82,6 @@ struct ptldebug_header {
> 	__u32 ph_line_num;
> } __attribute__((packed));
> 
>-
> #define PH_FLAG_FIRST_RECORD 1
> 
> /* Debugging subsystems (32 bits, non-overlapping) */
>@@ -199,8 +198,6 @@ do {								\
> 	       .msg_cdls   = (cdls)	 };			\
> 	dataname.msg_mask   = (mask);
> 
>-
>-
> /**
>  * Filters out logging messages based on mask and subsystem.
>  */
>@@ -231,9 +228,6 @@ do {									\
> 	__CDEBUG(&cdls, mask, format, ## __VA_ARGS__);			\
> } while (0)
> 
>-
>-
>-
> #define CWARN(format, ...)	  CDEBUG_LIMIT(D_WARNING, format, ##
>__VA_ARGS__)
> #define CERROR(format, ...)	 CDEBUG_LIMIT(D_ERROR, format, ##
>__VA_ARGS__)
> #define CNETERR(format, a...)       CDEBUG_LIMIT(D_NETERROR, format, ##
>a)
>@@ -248,7 +242,6 @@ do {									\
> 
> #define LCONSOLE_EMERG(format, ...) CDEBUG(D_CONSOLE | D_EMERG, format,
>## __VA_ARGS__)
> 
>-
> void libcfs_log_goto(struct libcfs_debug_msg_data *, const char *,
>long_ptr_t);
> #define GOTO(label, rc)							\
> do {									\
>@@ -261,7 +254,6 @@ do {									\
> 	goto label;							\
> } while (0)
> 
>-
> extern int libcfs_debug_msg(struct libcfs_debug_msg_data *msgdata,
> 			    const char *format1, ...)
> 	__attribute__ ((format (printf, 2, 3)));
>-- 
>1.7.5.4
>
>


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division




More information about the devel mailing list