[PATCHv3 0/13] Staging: vt6656: Cleanup of checkpatch problems in bssdb.c

Sebastian Rachuj sebastian.rachuj at studium.uni-erlangen.de
Sat Jan 4 15:25:05 UTC 2014


This patch series reformats the bssdb.c file of the vt6656 driver in
staging. It resolves all errors and some warnings which checkpatch.pl
discovered.

However some occurrences of the following warnings are not patched:
- Lines over 80 characters
- Too many indentation levels
- printk should include KERN_ facility level

The first two noted types of warnings require more code modification
to reduce the indentation level. The latter should be fixed along with
the removal of the custom printk macro in
drivers/staging/vt6656/device.h.

NOTE: As the first patch retabs the complete file, you might consider
using "git diff --ignore-all-space"

No functional changes should be introduced by these patches.

Changes for v3:
As noted by Dan Carpenter, a commit of us introduced bogus
parentheses to conform with the corrupt "coding style" that was used
in this file. Therefore we now added another commit that removes all
these parentheses altogether. Additionally another new commit
simplifies comparisons agains NULL. The first 9 patches remain
unchanged.

Changes for v2:
As requested, the changes are now split into a series of smaller,
fine-grained patches. The reference git tree, that was used to create
it this time, is linux-next.



More information about the devel mailing list