[PATCH, RFC 11/30] staging: panel: fix interruptible_sleep_on race
Arnd Bergmann
arnd at arndb.de
Thu Jan 2 12:07:35 UTC 2014
interruptible_sleep_on is racy and going away. This replaces the one
caller in the panel driver with the appropriate wait_event_interruptible
variant.
Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Cc: devel at driverdev.osuosl.org
Cc: Willy Tarreau <willy at meta-x.org>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
drivers/staging/panel/panel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index cbc15c1..ec4b1fd 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1590,8 +1590,8 @@ static ssize_t keypad_read(struct file *file,
if (file->f_flags & O_NONBLOCK)
return -EAGAIN;
- interruptible_sleep_on(&keypad_read_wait);
- if (signal_pending(current))
+ if (wait_event_interruptible(keypad_read_wait,
+ keypad_buflen != 0))
return -EINTR;
}
--
1.8.3.2
More information about the devel
mailing list