staging: comedi: USB devs not working / some comedi core reorganization

Dan Carpenter dan.carpenter at oracle.com
Thu Jan 2 08:10:07 UTC 2014


On Fri, Dec 20, 2013 at 11:48:31PM +0000, Bernd Porr wrote:
> >From 5971245d01f25890826fc05f7bab0d2b8d6bfd63 Mon Sep 17 00:00:00 2001
> From: Bernd Porr <mail at berndporr.me.uk>
> Date: Fri, 20 Dec 2013 23:32:08 +0000
> Subject: [PATCH 1/1] Moving un-registering of the subdevices and the main
>  comedi device into one function and the module which is responsible for file
>  operations. The kernel oops observed before was because the main device was
>  un-registered first and then the subdevices which were then no longer valid.
> 

When you are doing a git commit then the first line of the commit
message is the subject and then put a blank line followed by the body
of the commit message.

[PATCH] Staging: comedi: fix remove ordering

Bla blah blah explanation.  Put the warning message in the commit log
as well.

Really patches need to be sent inline and not as an attachment.  Greg
deals with too many patches and has scripts to handle inline patches and
has to handle attachments manually.  Everyone else has review scripts
for inline patches as well.
http://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/

regards,
dan carpenter



More information about the devel mailing list