[PATCH 63/66] staging: comedi: pcl816: tidy up the remaining register defines

H Hartley Sweeten hsweeten at visionengravers.com
Fri Feb 28 23:24:52 UTC 2014


For aesthetics, rename the clear INT request register.

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/pcl816.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
index 1c84066..6e2b857 100644
--- a/drivers/staging/comedi/drivers/pcl816.c
+++ b/drivers/staging/comedi/drivers/pcl816.c
@@ -44,12 +44,16 @@ Configuration Options:
 #include "comedi_fc.h"
 #include "8253.h"
 
+/*
+ * Register I/O map
+ */
 #define PCL816_DO_DI_LSB_REG			0x00
 #define PCL816_DO_DI_MSB_REG			0x01
 #define PCL816_TIMER_BASE			0x04
 #define PCL816_AI_LSB_REG			0x08
 #define PCL816_AI_MSB_REG			0x09
 #define PCL816_RANGE_REG			0x09
+#define PCL816_CLRINT_REG			0x0a
 #define PCL816_MUX_REG				0x0b
 #define PCL816_MUX_SCAN(_first, _last)		(((_last) << 4) | (_first))
 #define PCL816_CTRL_REG				0x0c
@@ -73,10 +77,6 @@ Configuration Options:
 #define PCL816_STATUS_INTACT			(1 << 6)
 #define PCL816_STATUS_DRDY			(1 << 7)
 
-/* W: clear INT request */
-#define PCL816_CLRINT 10
-
-
 #define MAGIC_DMA_WORD 0x5a5a
 
 static const struct comedi_lrange range_pcl816 = {
@@ -256,7 +256,7 @@ static void pcl816_ai_setup_chanlist(struct comedi_device *dev,
 static void pcl816_ai_clear_eoc(struct comedi_device *dev)
 {
 	/* writing any value clears the interrupt request */
-	outb(0, dev->iobase + PCL816_CLRINT);
+	outb(0, dev->iobase + PCL816_CLRINT_REG);
 }
 
 static void pcl816_ai_soft_trig(struct comedi_device *dev)
-- 
1.8.5.2



More information about the devel mailing list