[PATCH 07/08] staging:dgap: Fix externs should be avoided in .c files as reported by checkpatch

Mark Hounschell markh at compro.net
Fri Feb 28 17:42:14 UTC 2014


This patch fixes "externs should be avoided in .c files"
in dgap.c as reported by checkpatch

Signed-off-by: Mark Hounschell <markh at compro.net>
---
 drivers/staging/dgap/dgap.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index cfa33f9..b3f8c49 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -224,8 +224,8 @@ static void dgap_sysfs_create(struct board_t *brd);
 static int dgap_firmware_load(struct pci_dev *pdev, int card_type);
 
 /* Driver load/unload functions */
-int			dgap_init_module(void);
-void			dgap_cleanup_module(void);
+static int dgap_init_module(void);
+static void dgap_cleanup_module(void);
 
 module_init(dgap_init_module);
 module_exit(dgap_cleanup_module);
@@ -518,7 +518,7 @@ static struct toklist dgap_tlist[] = {
  *
  * Module load.  This is where it all starts.
  */
-int dgap_init_module(void)
+static int dgap_init_module(void)
 {
 	int rc = 0;
 
@@ -674,7 +674,7 @@ static void dgap_remove_one(struct pci_dev *dev)
  *
  * Module unload.  This is where it all ends.
  */
-void dgap_cleanup_module(void)
+static void dgap_cleanup_module(void)
 {
 	int i;
 	ulong lock_flags;
-- 
1.8.1.4



More information about the devel mailing list