[PATCH v5 1/2] imx-drm: ipu-dmfc: Remove unneeded 'dmfc' check

Philipp Zabel p.zabel at pengutronix.de
Fri Feb 28 14:45:39 UTC 2014


Hi Fabio,

Am Freitag, den 28.02.2014, 11:39 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> Fix the following static checker warning:
> 
> drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157)
> 
> As 'dmfc' could never be null, there is no need to do such check.
> 
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
> Changes since v4:
> - Remove the check instead of moving it earlier

Acked-by: Philipp Zabel <p.zabel at pengutronix.de>

I'll resend the move-out-of-staging patch rebased on top of this.

thanks
Philipp



More information about the devel mailing list