[PATCH v2] staging: dgap: fix kernel oops on port open

Dan Carpenter dan.carpenter at oracle.com
Fri Feb 28 14:12:42 UTC 2014


On Fri, Feb 28, 2014 at 08:56:37AM -0500, Mark Hounschell wrote:
> Thanks Dan. I see what should be done. I like and can work on this.
> But is it OK to save all the 80 char problems until the end of this
> next series or more likely a separate patch all together?

What ever you want to do is ok.  :P  Greg applies them on a first come
first serve basis.

In theory, you should sent bug fixes first.  Then my hint would be to
send the patches in the least controversial to most controversial.  That
way if you have to redo one it will be at the end and we can apply the
earlier ones.

Otherwise send them in whatever order you want.

> Since I'm trying to make individual patches that address specific
> checkpatch problems I am running into a chicken and egg sort of thing.
> Some of the next series will have checkpatch warnings/errors that are
> corrected in later patches.

It's fine for your patch to have checkpatch warnings if they were there
in the original code.  It's also fine if you change indentation and it
makes you go over the 80 character mark.

Common sense applies.

> Will this be OK? I think the review process will be much easier this
> way?

Fine fine.

Just send us what you have so far.  It's better to not get too big of
pile of patches until you get a feel for which things we are going to
complain about.

regards,
dan carpenter



More information about the devel mailing list