[PATCH v2] staging: ced401: fix double unlock bug

Greg KH gregkh at linuxfoundation.org
Tue Feb 25 00:43:57 UTC 2014


On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
> 
> After spin_lock() is called, all of if-else conditions in this brace
> should reach the end of else and spin_unlock() must be called.
> So It doesn't need to call spin_unlock() without a return statement
> for handling an error.
> 
> Also sparse says:
> drivers/staging/ced1401/usb1401.c:1080:28: warning:
>  context imbalance in 'Handle1401Esc' - unexpected unlock
> 
> Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com>

This patch doesn't apply to my tree, can you please redo it against
linux-next and resend it so that I can apply it?

thanks,

greg k-h


More information about the devel mailing list