[PATCH] staging: rtl8187se: fix checkpatch.pl issues

Greg KH gregkh at linuxfoundation.org
Mon Feb 24 23:47:38 UTC 2014


On Thu, Feb 20, 2014 at 01:05:31AM -0700, axel.rasmussen1 at gmail.com wrote:
> From: Axel Rasmussen <axel.rasmussen1 at gmail.com>
> Date: Mon, 17 Feb 2014 23:50:05 -0700
> Subject: [PATCH] staging: rtl8187se: fix checkpatch.pl issues

Please just use 'git send-email' so I don't have to hand-edit the patch
and strip this out :(

> 
> Reformatted many lines which were too long, replaced various printk
> calls with appropriate netdev_* calls, and fixed some spelling errors.

You did multiple things here to this patch, which should be a big hint
that you need to break it up into smaller pieces, each one doing just
one thing.  Please do so, otherwise as it is, this patch is way too big
to review.

thanks,

greg k-h


More information about the devel mailing list