[PATCH 30/87] staging: comedi: pcl816: remove 'ao_chanlist' from boardinfo

H Hartley Sweeten hsweeten at visionengravers.com
Mon Feb 17 21:27:04 UTC 2014


This member in the boardinfo is the same for all board types. Remove
it.

The comedi core will initalize the subdevice len_chanlist to 1 if it
is not set by the driver so remove the unnecessary initialization.

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/pcl816.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
index b2d857d..70f5c78 100644
--- a/drivers/staging/comedi/drivers/pcl816.c
+++ b/drivers/staging/comedi/drivers/pcl816.c
@@ -99,7 +99,6 @@ struct pcl816_board {
 	int ai_maxdata;
 	int ao_maxdata;
 	int ai_chanlist;
-	int ao_chanlist;
 };
 
 static const struct pcl816_board boardtypes[] = {
@@ -112,7 +111,6 @@ static const struct pcl816_board boardtypes[] = {
 		.ai_maxdata	= 0xffff,
 		.ao_maxdata	= 0xffff,
 		.ai_chanlist	= 1024,
-		.ao_chanlist	= 1,
 	}, {
 		.name		= "pcl814b",
 		.ai_ns_min	= 10000,
@@ -122,7 +120,6 @@ static const struct pcl816_board boardtypes[] = {
 		.ai_maxdata	= 0x3fff,
 		.ao_maxdata	= 0x3fff,
 		.ai_chanlist	= 1024,
-		.ao_chanlist	= 1,
 	},
 };
 
@@ -942,7 +939,6 @@ static int pcl816_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	s->subdev_flags = SDF_WRITABLE | SDF_GROUND;
 	s->n_chan = board->n_aochan;
 	s->maxdata = board->ao_maxdata;
-	s->len_chanlist = board->ao_chanlist;
 	s->range_table = &range_pcl816;
 	break;
 
-- 
1.8.5.2



More information about the devel mailing list