[PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check

Dan Carpenter dan.carpenter at oracle.com
Fri Feb 14 22:00:41 UTC 2014


On Fri, Feb 14, 2014 at 10:50:23PM +0100, Levente Kurusa wrote:
> Since MSR_AP is 0x3, ANDing it with 0xFC will never be true.
> Add a NOT operation to 0xFC so that we will AND with the last
> three bits which will result in a possibility that the condition
> will succeed.
> 
> Signed-off-by: Levente Kurusa <levex at linux.com>
> ---
>  Hi,
> 
>  This might not be the real solution since it is also possible that
>  the particular condition never really happens. I seek comments
>  so that I can post the proper patch.
> 

I can't test it either but I think your fix is correct.

Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>

regards,
dan carpenter



More information about the devel mailing list