[PATCH RFC 01/17] staging: dgap: Merge dgap_fep5.c into dgap_driver.c
Mark Hounschell
markh at compro.net
Wed Feb 12 21:39:13 UTC 2014
On 02/12/2014 03:34 PM, Dan Carpenter wrote:
> Greg mentioned doing the checkpatch.pl fixes later and that applies
> here as well. Leave the LINUX_VERSION_CODE code in for now and delete
> it in a later patch.
>
> On the other hand, I don't want to give you a lot of extra work to do if
> no one else cares...
>
> What I'm saying is that when you do moves, please *just* move the code
> exactly as unmodified as possible. I have tools to review that the code
> just shifted but was not modified.
>
> The truth is that when I review patches, I always pretend submitters
> work for the US government to sabotage things and insert backdoors. I
> want to verify that the patch does exactly what it says and nothing
> more.
>
Understood. I just sent v2 of the series. I hope all is OK.
Regards
Mark
More information about the devel
mailing list