[PATCH]staging: slicoss: Fix possible reuse of freed memory in timer function

Chris Harrer charrer at alacritech.com
Tue Feb 11 13:51:26 UTC 2014


Hi Denis,

I understand your frustration; it¹s not that we don¹t want to help, it¹s
that we¹ve moved onto other products.  As for getting H/W to people, I can
easily ship H/W within the United States; it¹s difficult for us to ship
internationally due to many different customs restrictions.  If there is
somewhere I can ship H/W in the states, I¹ll gladly do so.

Best regards,

Chris

On 2/11/14, 2:37 AM, "Denis Kirjanov" <kirjanov at gmail.com> wrote:

>On 2/10/14, Kirill Tkhai <tkhai at yandex.ru> wrote:
>> Do not call kfree() till timer function is finished.
>>
>> [This was found using grep. Compiled tested only]
>>
>> Signed-off-by: Kirill Tkhai <tkhai at yandex.ru>
>> CC: Joe Perches <joe at perches.com>
>> CC: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>
>CC Chris Harrer.
>
>The problem with that driver is that alacritech guys don't seem to
>care. Not sure if anyone has a hardware to test the driver and
>probably the code is completely broken.
>Probably the better option is to drop the code from the staging tree...
>
>> ---
>>  drivers/staging/slicoss/slicoss.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/staging/slicoss/slicoss.c
>> b/drivers/staging/slicoss/slicoss.c
>> index 1426ca4..e0de497 100644
>> --- a/drivers/staging/slicoss/slicoss.c
>> +++ b/drivers/staging/slicoss/slicoss.c
>> @@ -2970,7 +2970,7 @@ static void slic_card_cleanup(struct sliccard
>>*card)
>>  {
>>  	if (card->loadtimerset) {
>>  		card->loadtimerset = 0;
>> -		del_timer(&card->loadtimer);
>> +		del_timer_sync(&card->loadtimer);
>>  	}
>>
>>  	slic_debug_card_destroy(card);
>> _______________________________________________
>> devel mailing list
>> devel at linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>>
>
>
>-- 
>Regards,
>Denis




More information about the devel mailing list