[PATCH]staging: slicoss: Fix possible reuse of freed memory in timer function

Kirill Tkhai tkhai at yandex.ru
Mon Feb 10 18:36:23 UTC 2014


Do not call kfree() till timer function is finished.

[This was found using grep. Compiled tested only]

Signed-off-by: Kirill Tkhai <tkhai at yandex.ru>
CC: Joe Perches <joe at perches.com>
CC: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 1426ca4..e0de497 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -2970,7 +2970,7 @@ static void slic_card_cleanup(struct sliccard *card)
 {
 	if (card->loadtimerset) {
 		card->loadtimerset = 0;
-		del_timer(&card->loadtimer);
+		del_timer_sync(&card->loadtimer);
 	}

 	slic_debug_card_destroy(card);


More information about the devel mailing list