[PATCH net] hyperv: Fix the carrier status setting
Haiyang Zhang
haiyangz at microsoft.com
Mon Feb 10 15:57:55 UTC 2014
> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov at cogentembedded.com]
> Sent: Monday, February 10, 2014 8:29 AM
> To: Haiyang Zhang; davem at davemloft.net; netdev at vger.kernel.org
> Cc: KY Srinivasan; olaf at aepfle.de; jasowang at redhat.com; linux-
> kernel at vger.kernel.org; driverdev-devel at linuxdriverproject.org
> Subject: Re: [PATCH net] hyperv: Fix the carrier status setting
>
> Hello.
>
> On 10-02-2014 5:07, Haiyang Zhang wrote:
>
> > Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com>
> > Reviewed-by: K. Y. Srinivasan <kys at microsoft.com>
> > ---
> > drivers/net/hyperv/netvsc_drv.c | 24 +++++++++++++++---------
> > 1 files changed, 15 insertions(+), 9 deletions(-)
>
> > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > b/drivers/net/hyperv/netvsc_drv.c index 7756118..836211c 100644
> > --- a/drivers/net/hyperv/netvsc_drv.c
> > +++ b/drivers/net/hyperv/netvsc_drv.c
> [...]
> > @@ -229,15 +238,17 @@ void netvsc_linkstatus_callback(struct hv_device
> *device_obj,
> > struct net_device *net;
> > struct net_device_context *ndev_ctx;
> > struct netvsc_device *net_device;
> > + struct rndis_device *rdev;
> >
> > net_device = hv_get_drvdata(device_obj);
> > + rdev = net_device->extension;
> > +
> > + rdev->link_state = !(status == 1);
>
> Why not just 'status != 1'?
I will simplify it.
Thanks,
- Haiyang
More information about the devel
mailing list