[PATCH] drivers:staging:silicom: Fixed MACRO, Extern, parentheses Coding style warnings and errors

Dan Carpenter dan.carpenter at oracle.com
Mon Feb 10 09:18:42 UTC 2014


On Sun, Feb 09, 2014 at 07:05:24PM -0800, Surendra Patil wrote:
> Fixed MACRO,Extern and parentheses Coding style warnings and errors - listed only few
> bpctl_mod.c:120: WARNING: externs should be avoided in .c files
> bpctl_mod.c:121: WARNING: externs should be avoided in .c files
> bpctl_mod.c:122: WARNING: externs should be avoided in .c files
> bpctl_mod.c:124: WARNING: externs should be avoided in .c files
> bpctl_mod.c:125: WARNING: externs should be avoided in .c files
> bp_ioctl.h:54: ERROR: Macros with complex values should be enclosed in parenthesis
> bp_ioctl.h:159: ERROR: Macros with complex values should be enclosed in p arenthesis
> bpctl_mod.c:1395: WARNING: Unnecessary parentheses - maybe == should be = ?
> 

These don't seem to match the patch at all.

regards,
dan carpenter



More information about the devel mailing list