[PATCH] staging: bcm: fix pointer-integer size mismatch warnings
Dan Carpenter
dan.carpenter at oracle.com
Tue Feb 4 08:21:10 UTC 2014
On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote:
> Fix the pointer-integer size mismatch warnings below:
> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
> ^
> drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
> ^
> drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
> integer of different size [-Wint-to-pointer-cast]
> pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
> ^
No. You haven't fixed the bug, you've just silenced the warning so now
someone has to spent hours and hours looking for it when it comes time
to write a proper fix. Don't do that.
regards,
dan carpenter
More information about the devel
mailing list