[staging] unused rtl8192u/ieee80211/digest.c ?

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Feb 3 20:08:08 UTC 2014


On Mon, Feb 03, 2014 at 11:33:41AM -0800, Dave Hansen wrote:
> I was doing some code audits looking at scattergather uses, and noticed
> that update() in drivers/staging/rtl8192u/ieee80211/digest.c uses
> sg.page which doesn't exist any longer, so this can't possibly compile.
> 
> Turns out that digest.c is actually unused.  It doesn't get referenced
> in a Makefile or get compiled and doesn't get used as far as I can see.

Great, please send a patch to delete it :)

> This driver looks pretty dead.  The original author hasn't touched it in
> the 4 years since it got in to staging/.  Shouldn't we be kicking stuff
> like this out of staging?

Ther eare users of this hardware, so I can't delete it.  See the
relevant lkml thread the past few days about rtl wireless drivers for
all of the details as to the mess we have here.

thanks,

greg k-h


More information about the devel mailing list