[PATCHv2 5/8] staging: iio: isl29028: deprecate use of isl in compatible string for isil

Jonathan Cameron jic23 at kernel.org
Fri Dec 26 12:06:08 UTC 2014


On 16/12/14 21:20, Arnaud Ebalard wrote:
> 
> "isil" and "isl" prefixes are used at various locations inside the kernel
> to reference Intersil corporation. This patch is part of a series fixing
> those locations were "isl" is used in compatible strings to use the now
> expected "isil" prefix instead (NASDAQ symbol for Intersil and most used
> version). The old compatible string is kept for backward compatibility.
> 
> Signed-off-by: Arnaud Ebalard <arno at natisbad.org>
This is getting a little silly. 

I'll go with whatever the device tree maintainers decide. Hence if they are happy,
Acked-by: Jonathan Cameron <jic23 at kernel.org>
> ---
>  drivers/staging/iio/light/isl29028.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index e969107ddb47..6440e3b293ca 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -537,8 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
>  MODULE_DEVICE_TABLE(i2c, isl29028_id);
>  
>  static const struct of_device_id isl29028_of_match[] = {
> -	{ .compatible = "isl,isl29028", },
> -	{ .compatible = "isil,isl29028", },/* deprecated, don't use */
> +	{ .compatible = "isl,isl29028", }, /* for backward compat., don't use */
> +	{ .compatible = "isil,isl29028", },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, isl29028_of_match);
> 



More information about the devel mailing list