[PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Fix for possible null pointer dereference

Chris Rorvick chris at rorvick.com
Tue Dec 16 04:40:15 UTC 2014


On Sun, Dec 14, 2014 at 4:52 PM, Rickard Strandqvist
<rickard_strandqvist at spectrumdigital.se> wrote:
>         units = 1;
...
>         /* Specified units override the multiplier */
>         if (units)

That doesn't make much sense.  The conditional logic will always be
executed.  Maybe this is what's intended?

        /* Specified units override the multiplier */
-       if (units)
+       if (units > 1)
                mult = mult < 0 ? -units : units;

Chris


More information about the devel mailing list