[PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static
atull
atull at opensource.altera.com
Fri Dec 12 15:31:57 UTC 2014
On Thu, 11 Dec 2014, One Thousand Gnomes wrote:
> On Thu, 11 Dec 2014 09:43:24 +0800
> kbuild test robot <fengguang.wu at intel.com> wrote:
>
> > drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
>
> Ought to be const as well by the look of it - we don't want function
> pointers in patchable memory spaces.
>
I agree. Will be in v5.
Alan
More information about the devel
mailing list