[PATCH v4 1/2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines
Luis de Bethencourt
luis at debethencourt.com
Thu Dec 11 00:20:14 UTC 2014
On Wed, Dec 10, 2014 at 04:01:04PM -0800, Joe Perches wrote:
> On Wed, 2014-12-10 at 23:57 +0000, Luis de Bethencourt wrote:
> > On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> > > On Wed, 2014-12-10 at 22:33 +0000, Luis de Bethencourt wrote:
> > > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> []
> > > > + dev_err(tx->ir->l.dev,
> > > > + "unsupported code set file version (%u, expected 1) -- please upgrade to a newer driver",
> > > > + version);
> > >
> > > Unrelated but this one should have a '\n' termination
> > > at the end of the format.
> > I can add that change, no problem. As part of this patch or a third one?
>
> Up to you.
>
>
I like keeping my patches divided in functional units. Resubmitting these
patches as v5 with your suggestion as the third one, since it needs to be
applied on top of the other 2.
Thanks Joe!
Luis
More information about the devel
mailing list