[PATCH] Staging: lustre: Fix sparse non-static symbol warnings

Tom Wales twales518 at gmail.com
Mon Dec 8 22:06:28 UTC 2014


Fixes the following sparse warnings:

drivers/staging/lustre/lnet/lnet/lib-move.c:565:1: warning:
symbol 'lnet_ni_recv' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/lib-move.c:603:1: warning:
symbol 'lnet_setpayloadbuffer' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/lib-move.c:643:1: warning:
symbol 'lnet_ni_send' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/lib-move.c:658:1: warning:
symbol 'lnet_ni_eager_recv' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/lib-move.c:683:1: warning:
symbol 'lnet_ni_query_locked' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/lib-move.c:735:1: warning:
symbol 'lnet_peer_alive_locked' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/lib-move.c:874:19: warning:
symbol 'lnet_msg2bufpool' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/lib-move.c:895:1: warning:
symbol 'lnet_post_routed_recv_locked' was not declared. Should it be static?

Signed-off-by: Tom Wales <twales518 at gmail.com>
---
 drivers/staging/lustre/lnet/lnet/lib-move.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/drivers/staging/lustre/lnet/lnet/lib-move.c
index 4b9567d..5754725 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-move.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-move.c
@@ -561,7 +561,7 @@ lnet_extract_kiov(int dst_niov, lnet_kiov_t *dst,
 }
 EXPORT_SYMBOL(lnet_extract_kiov);
 
-void
+static void
 lnet_ni_recv(lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
 	     unsigned int offset, unsigned int mlen, unsigned int rlen)
 {
@@ -599,7 +599,7 @@ lnet_ni_recv(lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
 		lnet_finalize(ni, msg, rc);
 }
 
-void
+static void
 lnet_setpayloadbuffer(lnet_msg_t *msg)
 {
 	lnet_libmd_t *md = msg->msg_md;
@@ -639,7 +639,7 @@ lnet_prep_send(lnet_msg_t *msg, int type, lnet_process_id_t target,
 	msg->msg_hdr.payload_length = cpu_to_le32(len);
 }
 
-void
+static void
 lnet_ni_send(lnet_ni_t *ni, lnet_msg_t *msg)
 {
 	void   *priv = msg->msg_private;
@@ -654,7 +654,7 @@ lnet_ni_send(lnet_ni_t *ni, lnet_msg_t *msg)
 		lnet_finalize(ni, msg, rc);
 }
 
-int
+static int
 lnet_ni_eager_recv(lnet_ni_t *ni, lnet_msg_t *msg)
 {
 	int	rc;
@@ -679,7 +679,7 @@ lnet_ni_eager_recv(lnet_ni_t *ni, lnet_msg_t *msg)
 }
 
 /* NB: caller shall hold a ref on 'lp' as I'd drop lnet_net_lock */
-void
+static void
 lnet_ni_query_locked(lnet_ni_t *ni, lnet_peer_t *lp)
 {
 	unsigned long last_alive = 0;
@@ -731,7 +731,7 @@ lnet_peer_is_alive(lnet_peer_t *lp, unsigned long now)
 
 /* NB: returns 1 when alive, 0 when dead, negative when error;
  *     may drop the lnet_net_lock */
-int
+static int
 lnet_peer_alive_locked(lnet_peer_t *lp)
 {
 	unsigned long now = cfs_time_current();
@@ -871,7 +871,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
 }
 
 
-lnet_rtrbufpool_t *
+static lnet_rtrbufpool_t *
 lnet_msg2bufpool(lnet_msg_t *msg)
 {
 	lnet_rtrbufpool_t	*rbp;
@@ -891,7 +891,7 @@ lnet_msg2bufpool(lnet_msg_t *msg)
 	return rbp;
 }
 
-int
+static int
 lnet_post_routed_recv_locked(lnet_msg_t *msg, int do_recv)
 {
 	/* lnet_parse is going to lnet_net_unlock immediately after this, so it
-- 
1.9.1



More information about the devel mailing list