[PATCH 00/69] checkpatch fix series for Unisys drivers

Benjamin Romer benjamin.romer at unisys.com
Fri Dec 5 22:08:35 UTC 2014


This patch series contains all of the previously-submitted patches in order and
reviewed individually. The patches contain fixes based on errors, warnings,
and checks generated by checkpatch.pl, removal of log message macros, and fixes
to remove unnecessary goto statements.

Benjamin Romer (51):
  staging: unisys: fix line spacing in visorchipset_umode.h
  staging: unisys: fix line spacing in globals.h
  staging: unisys: remove testing.h
  staging: unisys: get rid of channel stub
  staging: unisys: remove unused types from visorchipset.h
  staging: unisys: add comment to spinlock in struct charqueue
  staging: unisys: clean up typecasts in uislib.c
  staging: unisys: fix alignment in uislib.c
  staging: unisys: refactor create_bus()
  staging: unisys: fix strict checks in create_device()
  staging: unisys: remove extraneous blank lines in uislib.c
  staging: unisys: add missing brackets in info_debugfs_read()
  staging: unisys: add missing brackets in Process_Incoming()
  staging: unisys: remove extra parens from
    uislib_enable_channel_interrupts()
  staging: unisys: get rid of doubled assignment in uislib_mod_init()
  staging: unisys: fix CamelCase global variable names in uislib.c
  staging: unisys: refactor init_vbus_channel()
  staging: unisys: fix CamelCase in create_bus()
  staging: unisys: fix CamelCase in destroy_bus()
  staging: unisys: refactor create_device()
  staging: unisys: refactor pause_device()
  staging: unisys: refactor resume_device()
  staging: unisys: refactor destroy_device()
  staging: unisys: refactor delete_bus_glue()
  staging: unisys: refactor delete_device_glue()
  staging: unisys: refactor info_debugfs_read()
  staging: unisys: refactor find_dev()
  staging: unisys: rename Process_Incoming()
  staging: unisys: rename Initialize_incoming_thread()
  staging: unisys: fix CamelCase Work queue name in uislib.c
  staging: unisys: fix spacing in uisqueue.c
  staging: unisys: fix CamelCase names in do_locked_client_insert()
  staging: unisys: fix line spacing in uisthread.c
  staging: unisys: fix line spacing in uisutils.c
  staging: unisys: fix spacing in uisutils.c
  staging: unisys: fix brackets in uisctrl_register_req_handler_ex()
  staging: unisys: refactor uisctrl_register_req_handler_ex()
  staging: unisys: refactor uisctrl_unregister_req_handler_ex()
  staging: unisys: fix CamelCase globals in uisutils.c
  staging: unisys: refactor req_handler_add()
  staging: unisys: refactor visorchipset_file_init()
  staging: unisys: fix CamelCase global variables in file.c
  staging: unisys: get rid of HAVE_UNLOCKED_IOCTL code
  staging: unisys: get rid of goto in visorchipset_open()
  staging: unisys: fix CamelCase in visorchipset_mmap()
  staging: unisys: get rid of goto in visorchipset_ioctl()
  staging: unisys: remove ERRDRV and related macros
  staging: unisys: remove DBGINF() macros
  staging: unisys: get rid of LOGINFO() macros
  staging: unisys: remove LOGVER() macros
  staging: unisys: get rid of LOGWRN() macro and uisklog.h

Bryan Thompson (4):
  staging: unisys: visorchannel: Rename CamelCase variable channelBytes
  staging: unisys: visorchannel: Rename CamelCase variable nQueues
  staging: unisys: visorchannel: Describe spinlocks in VISORCHANNEL_Tag
    struct
  staging: unisys: Remove VISORCHANNEL typedef

Ken Depro (14):
  staging: unisys: virthba: Remove unneeded spaces after casts
  staging: unisys: virthba: Fix open parenthesis alignment checks
  staging: unisys: virthba: Fix logical continuation checks
  staging: unisys: virthba: Remove blank lines before/after braces
  staging: unisys: virthba: Fix missing braces at end of if-else
    statements
  staging: unisys: virthba: Change alloc calls to use var name instead
    of type
  staging: unisys: virthba: Fix a couple checkpatch problems
  staging: unisys: virthba: Fix "else not useful after return" warning
  staging: unisys: virthba: Fix warnings regarding lines over 80
    characters
  staging: unisys: virthba: Fix a couple open parenthesis alignment
    issues
  staging: unisys: virthba: Fix CamelCase for Disk Add/Remove global
    variables
  staging: unisys: virthba: Fix remaining CamelCase global variables
  staging: unisys: virthba: Fix CamelCase for a couple function names
  staging: unisys: virthba: Fix CamelCase for local variables

 drivers/staging/unisys/Kconfig                     |   1 -
 drivers/staging/unisys/Makefile                    |   1 -
 drivers/staging/unisys/channels/Kconfig            |  10 -
 drivers/staging/unisys/channels/Makefile           |  11 -
 drivers/staging/unisys/channels/channel.c          | 219 -----
 drivers/staging/unisys/channels/chanstub.c         |  75 --
 drivers/staging/unisys/channels/chanstub.h         |  23 -
 drivers/staging/unisys/include/procobjecttree.h    |   1 -
 drivers/staging/unisys/include/timskmod.h          |  22 +-
 drivers/staging/unisys/include/uisqueue.h          |   1 -
 drivers/staging/unisys/include/uisutils.h          |   4 +-
 drivers/staging/unisys/include/uniklog.h           | 191 -----
 drivers/staging/unisys/uislib/Kconfig              |   2 +-
 drivers/staging/unisys/uislib/uislib.c             | 888 ++++++++++-----------
 drivers/staging/unisys/uislib/uisqueue.c           | 219 ++++-
 drivers/staging/unisys/uislib/uisthread.c          |  12 +-
 drivers/staging/unisys/uislib/uisutils.c           | 129 ++-
 drivers/staging/unisys/virthba/Kconfig             |   2 +-
 drivers/staging/unisys/virthba/virthba.c           | 620 +++++++-------
 drivers/staging/unisys/virtpci/virtpci.c           | 185 +++--
 drivers/staging/unisys/visorchannel/globals.h      |   1 -
 drivers/staging/unisys/visorchannel/visorchannel.h |  69 +-
 .../unisys/visorchannel/visorchannel_funcs.c       | 148 ++--
 .../unisys/visorchannel/visorchannel_main.c        |   4 +-
 drivers/staging/unisys/visorchipset/file.c         | 156 ++--
 drivers/staging/unisys/visorchipset/file.h         |   3 +-
 drivers/staging/unisys/visorchipset/globals.h      |   3 -
 drivers/staging/unisys/visorchipset/parser.c       |  39 +-
 drivers/staging/unisys/visorchipset/parser.h       |   1 -
 drivers/staging/unisys/visorchipset/testing.h      |  43 -
 drivers/staging/unisys/visorchipset/visorchipset.h |  55 --
 .../unisys/visorchipset/visorchipset_main.c        | 244 +++---
 .../unisys/visorchipset/visorchipset_umode.h       |   2 -
 drivers/staging/unisys/visorutil/charqueue.c       |   4 +-
 drivers/staging/unisys/visorutil/charqueue.h       |   1 -
 drivers/staging/unisys/visorutil/easyproc.c        |  26 +-
 .../staging/unisys/visorutil/memregion_direct.c    |  19 +-
 drivers/staging/unisys/visorutil/periodic_work.c   |  12 +-
 drivers/staging/unisys/visorutil/procobjecttree.c  |  30 +-
 drivers/staging/unisys/visorutil/visorkmodutils.c  |   1 -
 40 files changed, 1457 insertions(+), 2020 deletions(-)
 delete mode 100644 drivers/staging/unisys/channels/Kconfig
 delete mode 100644 drivers/staging/unisys/channels/Makefile
 delete mode 100644 drivers/staging/unisys/channels/channel.c
 delete mode 100644 drivers/staging/unisys/channels/chanstub.c
 delete mode 100644 drivers/staging/unisys/channels/chanstub.h
 delete mode 100644 drivers/staging/unisys/include/uniklog.h
 delete mode 100644 drivers/staging/unisys/visorchipset/testing.h

-- 
2.1.0



More information about the devel mailing list