[PATCH v3 2/2] staging: media: lirc: lirc_zilog.c: keep consistency in dev functions
Dan Carpenter
dan.carpenter at oracle.com
Fri Dec 5 12:28:55 UTC 2014
On Thu, Dec 04, 2014 at 10:35:24PM +0000, Luis de Bethencourt wrote:
> The previous patch switched some dev functions to move the string to a second
> line. Doing this for all similar functions because it makes the driver easier
> to read if all similar lines use the same criteria.
>
> Signed-off-by: Luis de Bethencourt <luis at debethencourt.com>
> ---
> drivers/staging/media/lirc/lirc_zilog.c | 155 +++++++++++++++++++++-----------
> 1 file changed, 102 insertions(+), 53 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> index 8814a7e..af46827 100644
> --- a/drivers/staging/media/lirc/lirc_zilog.c
> +++ b/drivers/staging/media/lirc/lirc_zilog.c
> @@ -322,7 +322,8 @@ static int add_to_buf(struct IR *ir)
> struct IR_tx *tx;
>
> if (lirc_buffer_full(rbuf)) {
> - dev_dbg(ir->l.dev, "buffer overflow\n");
> + dev_dbg(ir->l.dev,
> + "buffer overflow\n");
No. Don't do this. It's better if it is on one line.
regards,
dan carpenter
More information about the devel
mailing list