[PATCH v2 00/11] staging: comedi: addi_apci_1500: initial cleanup

[Ian Abbott]

On 03/12/14 18:25, H Hartley Sweeten wrote:
> This driver is pretty broken but in the current state its difficult to
> figure out where to fix it.
>
> Introduce a couple helper functions to handle the read/write and reset
> of the Z8536 CIO chip. This removes quite a bit of lines of code and
> makes the driver a _bit_ easier to follow.
>
> Tidy up the register map defines.
>
> Fix the interrupt handler so that the IRQ is properly shared.
>
> v2: spinlock protect the Z8536 indirect register access as suggested
>      by Ian Abbott
>
> H Hartley Sweeten (11):
>    staging: comedi: hwdrv_apci1500: introduce z8536_read()
>    staging: comedi: hwdrv_apci1500: introduce z8536_write()
>    staging: comedi: hwdrv_apci1500: introduce z8536_reset()
>    staging: comedi: addi_apci_1500: tidy up PCI Bar 1 register map
>    staging: comedi: addi_apci_1500: remove private data 'iobase'
>    staging: comedi: addi_apci_1500: remove private data 'i_IobaseReserved'
>    staging: comedi: addi_apci_1500: use amcc_s5933.h defines
>    staging: comedi: addi_apci_1500: rename private data 'i_IobaseAddon'
>    staging: comedi: addi_apci_1500: tidy up PCI Bar 2 register map
>    staging: comedi: addi_apci_1500: remove APCI1500_ADDRESS_RANGE
>    staging: comedi: addi_apci_1500: handle shared interrupt
>
>   .../comedi/drivers/addi-data/hwdrv_apci1500.c      | 1505 +++++---------------
>   drivers/staging/comedi/drivers/addi_apci_1500.c    |   32 +-
>   2 files changed, 404 insertions(+), 1133 deletions(-)
>

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-