[PATCH 1/2] android: fix reference leak in sync_fence_create

Maarten Lankhorst maarten.lankhorst at canonical.com
Thu Aug 14 09:53:38 UTC 2014


According to the documentation sync_fence_create takes ownership of the point,
not a reference on the point.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com>
Cc: Colin Cross <ccross at google.com>
---
 drivers/staging/android/sync.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e7b2e0234196..69139ce7420d 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -199,7 +199,6 @@ struct sync_fence *sync_fence_create(const char *name, struct sync_pt *pt)
 	fence->num_fences = 1;
 	atomic_set(&fence->status, 1);
 
-	fence_get(&pt->base);
 	fence->cbs[0].sync_pt = &pt->base;
 	fence->cbs[0].fence = fence;
 	if (fence_add_callback(&pt->base, &fence->cbs[0].cb,
-- 
2.0.4




More information about the devel mailing list