[PATCH v2 8/8] staging: comedi: amplc_dio200: remove dio200_common_detach()

Ian Abbott abbotti at mev.co.uk
Wed Aug 13 09:16:59 UTC 2014


On 2014-08-12 19:17, H Hartley Sweeten wrote:
> This exported function just does a free_irq() to release the interrupt
> handler for the legacy and PCI dio200 drivers.
>
> The legacy driver also calls comedi_legacy_detach() which would also
> do the free_irq(). For that driver the just use comedi_legacy_detach()
> directly for the (*detach).
>
> For the PCI driver, add the free_irq() to the private (*datach) function.
>
> Remove the, then unused, dio200_common_detach() function.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/amplc_dio200.c        | 8 +-------
>   drivers/staging/comedi/drivers/amplc_dio200.h        | 2 --
>   drivers/staging/comedi/drivers/amplc_dio200_common.c | 9 ---------
>   drivers/staging/comedi/drivers/amplc_dio200_pci.c    | 3 ++-
>   4 files changed, 3 insertions(+), 19 deletions(-)

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

(Other patches in the series already reviewed by me in previous iteration.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


More information about the devel mailing list