[PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.

Dan Carpenter dan.carpenter at oracle.com
Fri Aug 8 09:05:38 UTC 2014


On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote:
> This patch clear some code that was not doing any help.
> Pointed out by Larry.Finger
> 

The patch is fine but the changelog doesn't inpsire confidence.  It
should say:

This patch removes some unneeded code.
1) kzalloc() allocates 4 extra bytes so that we can align the return
   value.  But actually the return value is already aligned so we can
   remove the + 4 and the call to N_BYTE_ALIGMENT().
2) The memset() isn't needed because kzalloc() zeroes the allocation.

Suggested-by: Larry Finger <Larry.Finger at lwfinger.net>

regards,
dan carpenter



More information about the devel mailing list