[PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

Evgeny Budilovsky budevg at gmail.com
Thu Aug 7 11:13:50 UTC 2014


On Thu, Aug 7, 2014 at 12:42 AM, Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> On Wed, Aug 06, 2014 at 09:22:43PM +0300, Evgeny Budilovsky wrote:
>>
>>
>> Signed-off-by: Evgeny Budilovsky <budevg at gmail.com>
>
> Why is this needed?  Is the current code a bug?  Where was the reference
> added?  Is this causing a problem without this patch applied?  How far
> back should it be backported, if at all?
>
> I need lots more details here before I can take this patch, sorry.

Sorry for the little information in the previous mail.

The motivation for this patch was to clean some of the warnings that
were generated
on drivers/staging by the sparse utility.

For this particular case the warning was
staging/lustre/lustre/llite/lproc_llite.c:913:51: warning: dereference
of noderef expression

And this is since current->real_parent is accessed directly and not
trough the rcu_dereference,
which is the common way to access it throughout the kernel.

This is not a critical bug and in the worst case the code here may
cause miss of statistics counter increase.
This is why I think it is not worth to backport the patch at all.

>
> greg k-h



-- 
Best Regards,
Evgeny


More information about the devel mailing list