[PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()

Joe Perches joe at perches.com
Mon Aug 4 11:12:12 UTC 2014


On Mon, 2014-08-04 at 13:40 +0300, Dan Carpenter wrote:
> On Mon, Aug 04, 2014 at 12:17:14PM +0200, Martin Kepplinger wrote:
[]
> > +	if (dev) {
> > +		dev_dbg(&dev->bus_adap.usb_dev->dev,
> > +		"tuner parameters: freq: %d  bw: 0x%02x  gi: 0x%02x\n",
> > +			params->frequency,
> > +			tune_args->bandwidth,
> > +			tune_args->guard_interval);
> > +	} else {
> > +	pr_debug("as102: tuner parameters: freq: %d  bw: 0x%02x  gi: 0x%02x\n",
> >  			params->frequency,
> >  			tune_args->bandwidth,
> >  			tune_args->guard_interval);
> > +	}
[]
> This isn't indented correctly.  I wish checkpatch.pl would catch that...
> Anyway, the else side can be removed as explained earlier.

checkpatch doesn't warn on any of:

$ cat t.c
static int func(void **bar)
{
	bool b;
			/* test */
		int a[2] = {
			3,
				6
	};

		if (b) {
			b = a[0] == a[1];
	}
			return a[b];
	}
$

I think it'd be better if it would one day
but it doesn't seem as simple as it seems
for checkpatch to do it.



More information about the devel mailing list