[PATCH 00/12] staging: comedi: adv_pci1710: more async command cleanup
Ian Abbott
abbotti at mev.co.uk
Tue Apr 29 13:51:50 UTC 2014
On 2014-04-28 18:41, H Hartley Sweeten wrote:
> This continues the cleanup of the async command support code for this driver
> and addresses a number of issues pointed out by Ian Abbott.
>
> H Hartley Sweeten (12):
> staging: comedi: adv_pci1710: tidy up pci171x_ai_check_chanlist()
> staging: comedi: adv_pci1710: don't check the chanlist twice
> staging: comedi: adv_pci1710: remove 'neverending_ai' from private data
> staging: comedi: adv_pci1710: remove 'ai_buf_ptr' from private data
> staging: comedi: adv_pci1710: remove 'ai_eos' from private data
> staging: comedi: adv_pci1710: only calc the pacer divisors once
> staging: comedi: adv_pci1710: remove local var in pci171x_ai_cmd()
> staging: comedi: adv_pci1710: tidy up start_pacer()
> staging: comedi: adv_pci1710: rename interrupt helper functions
> staging: comedi: adv_pci1710: always enable PCI171x_PARANOIDCHECK code
> staging: comedi: adv_pci1710: remove 'i8254_osc_base' from private data
> staging: comedi: adv_pci1710: remove 'ai_act_chan' from private data
>
> drivers/staging/comedi/drivers/adv_pci1710.c | 431 +++++++++++----------------
> 1 file changed, 182 insertions(+), 249 deletions(-)
>
Looks good apart from a typo bug in patch 08/12 that I missed the first
time these patches were posted.
Reviewed-by: Ian Abbott <abbotti at mev.co.uk>
for patches 01-07,09-12
Feel free to add me as a Reviewed-by for patch 08 once the typo bug is
corrected.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti at mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
More information about the devel
mailing list