[PATCH V1 net-next 1/1] hyperv: Properly handle checksum offload

David Miller davem at davemloft.net
Mon Apr 28 17:23:47 UTC 2014


From: "K. Y. Srinivasan" <kys at microsoft.com>
Date: Fri, 25 Apr 2014 20:55:23 -0700

> @@ -467,6 +467,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
>  	if (skb_is_gso(skb))
>  		goto do_lso;
>  
> +	if (skb->ip_summed != CHECKSUM_PARTIAL)
> +		goto do_send;
> +

There are many possible values of ip_summed, why would you go to do_send if
for example it was set to CHECKSUM_COMPLETE?

I think you are just rushing this change, take your time and implement the
fix properly.

For example, if you only expect two possible values here (CHECKSUM_PARTIAL
and something else), design your test so that it only allows those two
values and therefore you'll be documenting this invariant.


More information about the devel mailing list