[PATCH] staging: silicom: Remove unused pointer in bypass_init_module()

Dan Carpenter dan.carpenter at oracle.com
Mon Apr 28 09:30:29 UTC 2014


On Sat, Apr 26, 2014 at 10:15:04PM +0200, Christian Engelmayer wrote:
> Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused.
> Thus remove it.
> 
> Signed-off-by: Christian Engelmayer <cengelma at gmx.at>
> ---
> Compile tested and applies against v3.15-rc2 as well as branch staging-next
> of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> ---
>  drivers/staging/silicom/bpctl_mod.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
> index 7f3d884..2bf8964 100644
> --- a/drivers/staging/silicom/bpctl_mod.c
> +++ b/drivers/staging/silicom/bpctl_mod.c
> @@ -6372,13 +6372,10 @@ static int __init bypass_init_module(void)
>  	sema_init(&bpctl_sema, 1);
>  	spin_lock_init(&bpvm_lock);
>  	{
> -
> -		struct bpctl_dev *pbpctl_dev_c = NULL;

The code is indented so that it can do that declaration.  Now the you
have removed the declaration, please remove the indent block '{' as
well.

This still falls under the one thing per patch rule because fixing the
indenting and removing the unused declaration are closely related.

regards,
dan carpenter



More information about the devel mailing list