[PATCH 02/03] staging: dgap: remove two unnecessary conditionals

Mark Hounschell markh at compro.net
Fri Apr 25 17:10:19 UTC 2014


Remove 2 unnessessary conditionals. They are always
false in this code path.

Signed-off-by: Mark Hounschell <markh at compro.net>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/dgap/dgap.c | 32 ++++++++++++++------------------
 1 file changed, 14 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 2c7acee..b834c83 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -1271,25 +1271,21 @@ static int dgap_tty_register(struct board_t *brd)
 	 */
 	tty_set_operations(brd->PrintDriver, &dgap_tty_ops);
 
-	if (!brd->dgap_Major_Serial_Registered) {
-		/* Register tty devices */
-		rc = tty_register_driver(brd->SerialDriver);
-		if (rc < 0)
-			return rc;
-		brd->dgap_Major_Serial_Registered = TRUE;
-		dgap_BoardsByMajor[brd->SerialDriver->major] = brd;
-		brd->dgap_Serial_Major = brd->SerialDriver->major;
-	}
+	/* Register tty devices */
+	rc = tty_register_driver(brd->SerialDriver);
+	if (rc < 0)
+		return rc;
+	brd->dgap_Major_Serial_Registered = TRUE;
+	dgap_BoardsByMajor[brd->SerialDriver->major] = brd;
+	brd->dgap_Serial_Major = brd->SerialDriver->major;
 
-	if (!brd->dgap_Major_TransparentPrint_Registered) {
-		/* Register Transparent Print devices */
-		rc = tty_register_driver(brd->PrintDriver);
-		if (rc < 0)
-			return rc;
-		brd->dgap_Major_TransparentPrint_Registered = TRUE;
-		dgap_BoardsByMajor[brd->PrintDriver->major] = brd;
-		brd->dgap_TransparentPrint_Major = brd->PrintDriver->major;
-	}
+	/* Register Transparent Print devices */
+	rc = tty_register_driver(brd->PrintDriver);
+	if (rc < 0)
+		return rc;
+	brd->dgap_Major_TransparentPrint_Registered = TRUE;
+	dgap_BoardsByMajor[brd->PrintDriver->major] = brd;
+	brd->dgap_TransparentPrint_Major = brd->PrintDriver->major;
 
 	return rc;
 }
-- 
1.8.4.5



More information about the devel mailing list