[PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

Andev debiandev at gmail.com
Thu Apr 24 21:49:41 UTC 2014


On Wed, Apr 23, 2014 at 5:24 PM, K. Y. Srinivasan <kys at microsoft.com> wrote:

>  drivers/net/hyperv/hyperv_net.h |   14 +++
>  drivers/net/hyperv/netvsc.c     |  226 +++++++++++++++++++++++++++++++++++++--
>  drivers/net/hyperv/netvsc_drv.c |    3 +->  3 files changed, 234 insertions(+), 9 deletions(-)

I just looked over netvsc.c and it could definitely use a more
consistent coding style.

Your use of goto exit/cleanup in some functions and returning directly
on errors in others could use a cleanup. Please consider doing that
while you are touching those files.


More information about the devel mailing list