[PATCH] staging: silicom: remove redundant pci_get_drvdata() call
DaeSeok Youn
daeseok.youn at gmail.com
Wed Apr 23 11:19:35 UTC 2014
2014-04-23 17:35 GMT+09:00, Dan Carpenter <dan.carpenter at oracle.com>:
> On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote:
>> The pci_get_drvdata() and checking NULL for dev are
>> called twice in while loop in is_bypass_dev().
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com>
>> ---
>> This patch has an warning from checkpatch.pl.
>> checkpatch.pl warning:
>> WARNING: Too many leading tabs - consider code refactoring
>
> No problem. Those were there and worse before your patch.
>
> If someone wanted to fix these then just reverse every if condition in
> the function.
Ok. Thanks for comment.
Regards,
Daeseok Youn
>
> regards,
> dan carpenter
>
>
More information about the devel
mailing list