[PATCH 2/2 v3] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

[Chase Southwood]

>On Wednesday, April 16, 2014 7:04 PM, Hartley Sweeten <HartleyS at visionengravers.com> wrote:

>>On Wednesday, April 16, 2014 4:53 PM, Chase Southwood wrote:
>>>On Wednesday, April 16, 2014 6:36 PM, Hartley Sweeten <HartleyS at visionengravers.com> wrote:
>>>>On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote:
>>>>Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c.  The
>>>>function was very messy and failed to reset a couple registers, these
>>>>issues were fixed on the move.>
>>>
>>>The commit message needs updated. You are no longer moving the function.
>>>
>>
>>Erm...in the PATCH v3 I just sent, it has been moved as described here, so at least for
>>what is happening now, this changelog is accurate.  Would you like me to no longer move
>>the function for the time being?
>
>Ah, missed that you moved it before the struct addi_board definition.
>
>Hmmm... I think it would be cleaner if you moved the function after separating
>this driver from the addi_common.c file. Then the moved functions can be put
>into the driver in "cleaner" locations and avoid any forward declaration junk.
>
>The brute force way to do this is just copy the contents of addi_common.c to
>the driver and remove the #include. Then you can move the functions from
>the hwrdv_apci1564.c file to the driver, and remove them from the boardinfo,
>as needed.
>
>Once you get the addi_common.c stuff localized you should fine that much
>of it is just NOP code for this driver. Those pieces then just need to be ripped
>out.
>
>Have fun...
>
>
>Hartley


OK, sounds good.  I'll submit a final version of this patch which just fixes the reset function without moving it, and then I will proceed according to this suggestion.

Thank you,
Chase