[PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

KY Srinivasan kys at microsoft.com
Mon Apr 14 17:09:49 UTC 2014



> -----Original Message-----
> From: H. Peter Anvin [mailto:hpa at zytor.com]
> Sent: Monday, April 14, 2014 10:08 AM
> To: KY Srinivasan; x86 at kernel.org; gregkh at linuxfoundation.org; linux-
> kernel at vger.kernel.org; devel at linuxdriverproject.org; olaf at aepfle.de;
> apw at canonical.com; jasowang at redhat.com; tglx at linutronix.de;
> JBeulich at suse.com
> Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
> appropriately
> 
> On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> > +	new_val = inb(PIC_MASTER_IMR);
> > +	if (probe_val != new_val) {
> 
> Nitpick: Linux coding style should have this as:
> 
> 	if (new_val != probe_val)
> 
> 	-hpa
> 
Will address this as well.

K. Y


More information about the devel mailing list